Makefile: Add target build #459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kata-containers's ci will re-build and re-install golangci-lint every time it did the staic check. So run test of golangci-lint with build will make it slow. Add target build to make golangci-lint just build but not test. Fixes: golangci#458 Signed-off-by: Hui Zhu <[email protected]>
|
|
|
I didn't understand what did you mean but I've merged it. I guess you need to install golangci-lint as a binary release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kata-containers's ci will re-build and re-install golangci-lint every
time it did the staic check.
So run test of golangci-lint with build will make it slow.
Add target build to make golangci-lint just build but not test.
Fixes: #458
Signed-off-by: Hui Zhu [email protected]
Thank you for the pull request!
Please make sure you didn't directly change
README.md: it should be changed only by changingREADME.tmpl.mdand runningmake readme.