Skip to content

dev: add test for grouper linter #4585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 28, 2024
Merged

dev: add test for grouper linter #4585

merged 3 commits into from
Mar 28, 2024

Conversation

alexandear
Copy link
Member

@alexandear alexandear commented Mar 28, 2024 •
edited by ldez
Loading

This PR adds an integration test for grouper:

T=grouper.go make test_linters

@alexandear alexandear added the area: tests Continuous integration, tests and other checks label Mar 28, 2024
alexandear
alexandear commented Mar 28, 2024
View reviewed changes
@alexandear alexandear marked this pull request as ready for review March 28, 2024 15:34
@ldez ldez added this to the next milestone Mar 28, 2024
ldez
ldez approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 07ffe48 into golangci:master Mar 28, 2024
13 checks passed
@alexandear alexandear deleted the test/add-grouper branch March 28, 2024 20:28
@ldez ldez modified the milestones: next, v1.58 May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area: tests Continuous integration, tests and other checks
Projects
None yet
Milestone
v1.58
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandear @ldez