dev: refactor .golangci.yml configuration and fix up nolintlint issues #4537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's usually OK to have long lines and duplicated code in tests.
Because the creation logic is similar between linters.
pkg/golinters/goanalysis/runner.go:180:1: unnamedResult: consider giving a name to these results (gocritic)
func (r *runner) prepareAnalysis(pkgs []*packages.Package,
^
pkg/golinters/goanalysis/runners.go:223:5: rangeValCopy: each iteration copies 128 bytes (consider pointers or indexing) (gocritic)
for _, i := range pkgIssues {
^
pkg/golinters/goanalysis/runners.go:187:1: unnamedResult: consider giving a name to these results (gocritic)
func loadIssuesFromCache(pkgs []*packages.Package, lintCtx *linter.Context,
^
pkg/golinters/gofmt_common.go:136:33: appendAssign: append result not assigned to the same slice (gocritic)
change.Replacement.NewLines = append(p.replacementLinesToPrepend, addedLines...)
^
Change nolintlint configuration: - require an explanation for nolint directives - to be specific about which linter is being skipped Fix up nolintlint issues by adding explanation comments.
ldez
force-pushed
the
feat/refactor-nolintlint
branch
from
24c13aa to
6fd95fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes
nolintlintissues and refactorsnolintlintconfiguration forgolangci-lintrepo.Main changes:
duplandlllfor tests and remove//nolint:dupl,//nolint:lll. Usually, it's OK to have duplicated code and long lines in tests.duplfor thepkg/golinterspackage and remove//nolint:dupl. Because the logic of creating linters is similar between linters.misspelledimportasbecause it's a linter.gocriticissues and remove//nolint:gocriticcomments.//nolint:<linter>.One commit one change.