-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
docs: define linter deprecation cycle #4474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could, given that the new plugin system lands, write a note about that. Because people will get upset because their favorite linter that works great with Go 1.13 now is gone! We can then add a note saying that the consumer of the linter can implement that exact linter as a plugin and keep using it.
We don't have to go into detail, just saying that it's possible and link to those parts of the docs.
Co-authored-by: Simon Sawert <[email protected]>
I agree. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
After more thinking, we can't recommend/suggest using a plugin for a deprecated linter. The linter needs to be modified, but if it is archived it will not be possible. And if the linter doesn't work with the current Go version, it will not work, even as a plugin, even with an older version of Go, because our code base also depends on a minimal Go version. Talking about plugins in this section will be confusing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I feel like we agree on my proposal, and then I propose to explain it in the documentation.
Fixes #1987