dev: rewrite linters Manager #4419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
enhancement
ldez
force-pushed
the
feat/rewrite-manager
branch
2 times, most recently
from
925b221 to
5737c95
Compare
bombsimon
approved these changes
Feb 28, 2024
ldez
force-pushed
the
feat/rewrite-manager
branch
from
9ddce62 to
4daab12
Compare
|
Even if I'm impatient to merge this PR, we will wait a bit for feedback from @Antonboom |
Co-authored-by: Simon Sawert <[email protected]>
ldez
force-pushed
the
feat/rewrite-manager
branch
from
4daab12 to
9d196f4
Compare
alexandear
approved these changes
Feb 29, 2024
ldez
force-pushed
the
feat/rewrite-manager
branch
from
d2a825e to
83c68d6
Compare
Antonboom
approved these changes
Mar 2, 2024
| } | ||
|
|
||
| if l.DisableAll { | ||
| if len(l.Enable) == 0 && len(l.Presets) == 0 { |
There was a problem hiding this comment.
cosmetic: gocritic also highlights that linters were already enabled or disabled via presets
There was a problem hiding this comment.
gocritic handles its own rules, not our linters or presets.
There was a problem hiding this comment.
of course, I meant checkers
just to do it for linters too, for analogy
There was a problem hiding this comment.
So I don't understand what is your suggestion here.
ldez
force-pushed
the
feat/rewrite-manager
branch
from
0a3a59f to
ad6b6e3
Compare
|
@bombsimon @Antonboom Be prepared because after this merge I will open 6 PRs (5 today and 1 later) 😸 Note: every time I want to add you both as reviewers I laugh because of your login: I put a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just put a log inside the methods used to build/load linters/plugins, and validate linters in the configuration.
You can see the problem easily.
Before the PR #4404:
After the PR #4404:
With this PR:
This behavior has been here since nearly the beginning of golangci-lint but the problem has increased with time.
Summary of the execution after #4404, #4412, and this PR:
config.Loader.Load).linterdb.NewManager).linterdb.LinterBuilder.Build,linterdb.PluginBuilder.Build)linterdb.Validator.Validate)Everything is done once and only once.
The improvement of the performance is not high, but the impact on debugging and maintainability is huge!
Next Step
A proposal for a new flag option and a bit of cleaning.