Allow exit failure only on specified severities #3926
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow golangci-lint runs to exit with failed statuses only on specified issue severities
Fixes #1981
Details
severity.fail-on-severities
string slice config option as well as--fail-on-severities
string slice commandline option
values specified in the option
Notes / Concerns
e.g. fail on warnings and above. A more sophisticated solution would need to establish total orderings of error
severities across each output format and possibly across output formats, which is annoying to maintain and may
confuse users.
nonempty config lists; this is not that hard to fathom for users, since never exiting with a failed code is not too
useful.
counterintuitive for the above reason.
Testing
warnings will fail