gci: improve error message #3777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds custom-order flag Supports gci StringArray breaking change introduced in version 0.10.0. CSV-style `-s one,two,three` must now be `use -s one -s two -s three` which now supports multiple prefixes. Fixes golangci#3776
|
Hey, thank you for opening your first Pull Request ! |
|
|
ldez
added
linter: update
ldez
changed the title
|
Hello, your PR only changes the error message. The feature is already implemented, and your tests prove that. |
ldez
changed the title
You are indeed correct, of course! I was flipping between two different golangci-lint and, thus, bundled gci versions - split between its multi-prefix support, and my own config had two prefixes. The error message threw me, as suggestion didn't work in my standalone, newer gci as the flags changed. All is well, thanks for the hard work and fast response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds custom-order flagSupports gci StringArray breaking change introduced in version 0.10.0. CSV-style-s one,two,threemust now beuse -s one -s two -s threewhich now supports multiple prefixes.Fixes #3776Improve error message.