fix: improve panic management #3710

ldez · 2023-03-19T18:22:25Z

Related to #3086

before the PR

$ golangci-lint cache clean && golangci-lint run  --disable-all --print-issued-lines=false -Ebodyclose 
ERRO [runner] Panic: bodyclose: package "ent" (isInitialPkg: true, needAnalyzeSource: true): interface conversion: interface {} is nil, not *buildssa.SSA: goroutine 1176 [running]:
runtime/debug.Stack()
        runtime/debug/stack.go:24 +0x65
github.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*action).analyzeSafe.func1()
        github.com/golangci/golangci-lint/pkg/golinters/goanalysis/runner_action.go:102 +0x155
panic({0xfd4880, 0xc0022ec060})
        runtime/panic.go:884 +0x213
github.com/timakin/bodyclose/passes/bodyclose.runner.run({0xc00157a0f0, {0x0, 0x0}, 0x0, {0x0, 0x0}, 0x0, 0x0}, 0xc00157a0f0)
        github.com/timakin/[email protected]/passes/bodyclose/bodyclose.go:45 +0x665
github.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*action).analyze(0xc0005a7aa0)
        github.com/golangci/golangci-lint/pkg/golinters/goanalysis/runner_action.go:188 +0xa25
github.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*action).analyzeSafe.func2()
        github.com/golangci/golangci-lint/pkg/golinters/goanalysis/runner_action.go:106 +0x1d
github.com/golangci/golangci-lint/pkg/timeutils.(*Stopwatch).TrackStage(0xc0004cafa0, {0x111e265, 0x9}, 0xc00011f748)
        github.com/golangci/golangci-lint/pkg/timeutils/stopwatch.go:111 +0x4a
github.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*action).analyzeSafe(0xc000c8a900?)
        github.com/golangci/golangci-lint/pkg/golinters/goanalysis/runner_action.go:105 +0x85
github.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*loadingPackage).analyze.func2(0xc0005a7aa0)
        github.com/golangci/golangci-lint/pkg/golinters/goanalysis/runner_loadingpackage.go:80 +0xb4
created by github.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*loadingPackage).analyze
        github.com/golangci/golangci-lint/pkg/golinters/goanalysis/runner_loadingpackage.go:75 +0x208 
WARN [runner] Can't run linter bodyclose: bodyclose: bodyclose: package "ent" (isInitialPkg: true, needAnalyzeSource: true): interface conversion: interface {} is nil, not *buildssa.SSA 
ERRO Running error: 1 error occurred:
        * can't run linter bodyclose: bodyclose: bodyclose: package "ent" (isInitialPkg: true, needAnalyzeSource: true): interface conversion: interface {} is nil, not *buildssa.SSA

With the PR

$ ./golangci-lint cache clean && ./golangci-lint run  --disable-all --print-issued-lines=false -Ebodyclose
ERRO [linters_context/goanalysis] panic during analysis: in github.com/Antonboom/golangci-vs-ent-generics/ent.withHooks$1: cannot convert *t0 (M) to PM, goroutine 257 [running]:
runtime/debug.Stack()
        /usr/lib/go/src/runtime/debug/stack.go:24 +0x65
github.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*action).analyzeSafe.func1()
        /home/ldez/sources/go/src/github.com/golangci/golangci-lint/pkg/golinters/goanalysis/runner_action.go:106 +0x6b
panic({0x1555d00, 0xc0016dac60})
        /usr/lib/go/src/runtime/panic.go:884 +0x213
golang.org/x/tools/go/ssa.emitConv(0xc0005b9e00, {0x199f1e0, 0xc003a7bb00}, {0x1996750?, 0xc001a7c9f0})
        /home/ldez/sources/go/pkg/mod/golang.org/x/[email protected]/go/ssa/emit.go:286 +0xdbc
golang.org/x/tools/go/ssa.emitStore(0xc0005b9e00, {0x199f1e0, 0xc003a7ba40}, {0x199f1e0, 0xc003a7bb00}, 0x2a9377e)
        /home/ldez/sources/go/pkg/mod/golang.org/x/[email protected]/go/ssa/emit.go:377 +0x5f
golang.org/x/tools/go/ssa.(*address).store(0xc0019a93b0, 0xc0005b9e00?, {0x199f1e0?, 0xc003a7bb00?})
        /home/ldez/sources/go/pkg/mod/golang.org/x/[email protected]/go/ssa/lvalue.go:40 +0x47
golang.org/x/tools/go/ssa.(*storebuf).emit(...)
        /home/ldez/sources/go/pkg/mod/golang.org/x/[email protected]/go/ssa/builder.go:533
golang.org/x/tools/go/ssa.(*builder).assignStmt(0xc0005b9e00?, 0xc0005b9e00, {0xc00120c2e0, 0x1, 0x16cb940?}, {0xc00120c2f0, 0x1, 0xc00317e7b0?}, 0x0)
        /home/ldez/sources/go/pkg/mod/golang.org/x/[email protected]/go/ssa/builder.go:1207 +0x43d
golang.org/x/tools/go/ssa.(*builder).stmt(0xc00317e8e8?, 0xc0005b9e00, {0x1999650?, 0xc00120e640?})
        /home/ldez/sources/go/pkg/mod/golang.org/x/[email protected]/go/ssa/builder.go:2181 +0x425
golang.org/x/tools/go/ssa.(*builder).stmtList(0xc00317e901?, 0xc0019a9170?, {0xc00120e680?, 0x4, 0xc000185000?})
        /home/ldez/sources/go/pkg/mod/golang.org/x/[email protected]/go/ssa/builder.go:946 +0x45
golang.org/x/tools/go/ssa.(*builder).stmt(0xc0005b9e00?, 0xc0005b9e00, {0x1999770?, 0xc001201140?})
        /home/ldez/sources/go/pkg/mod/golang.org/x/[email protected]/go/ssa/builder.go:2277 +0x859
golang.org/x/tools/go/ssa.(*builder).buildFunctionBody(0x0?, 0xc0005b9e00)
        /home/ldez/sources/go/pkg/mod/golang.org/x/[email protected]/go/ssa/builder.go:2391 +0x437
golang.org/x/tools/go/ssa.(*builder).expr0(0xc00317fa38, 0xc0038a7800, {0x1999a10?, 0xc00120c320?}, {0x7, {0x1996660, 0xc0020b9340}, {0x0, 0x0}})
        /home/ldez/sources/go/pkg/mod/golang.org/x/[email protected]/go/ssa/builder.go:656 +0x4d6
golang.org/x/tools/go/ssa.(*builder).expr(0x15c4140?, 0xc0038a7800, {0x1999a10, 0xc00120c320})
        /home/ldez/sources/go/pkg/mod/golang.org/x/[email protected]/go/ssa/builder.go:625 +0x17b
golang.org/x/tools/go/ssa.(*builder).expr0(0xc00317fa38, 0xc0038a7800, {0x19997d0?, 0xc00120e700?}, {0x7, {0x19965e8, 0xc0013f5dc0}, {0x0, 0x0}})
        /home/ldez/sources/go/pkg/mod/golang.org/x/[email protected]/go/ssa/builder.go:676 +0x705
golang.org/x/tools/go/ssa.(*builder).expr(0xc003a7b440?, 0xc0038a7800, {0x19997d0, 0xc00120e700})
        /home/ldez/sources/go/pkg/mod/golang.org/x/[email protected]/go/ssa/builder.go:625 +0x17b
golang.org/x/tools/go/ssa.(*builder).assign(0xc0038a7800?, 0xc0038a7800?, {0x199c0e8?, 0xc0019a90e0}, {0x19997d0?, 0xc00120e700?}, 0x8?, 0x0)
        /home/ldez/sources/go/pkg/mod/golang.org/x/[email protected]/go/ssa/builder.go:598 +0x3db
golang.org/x/tools/go/ssa.(*builder).localValueSpec(0xc0038a7800?, 0xc0038a7800, 0xc0011a7ea0)
        /home/ldez/sources/go/pkg/mod/golang.org/x/[email protected]/go/ssa/builder.go:1147 +0xe5
golang.org/x/tools/go/ssa.(*builder).stmt(0xc00317f598?, 0xc0038a7800, {0x19998c0?, 0xc00120c360?})
        /home/ldez/sources/go/pkg/mod/golang.org/x/[email protected]/go/ssa/builder.go:2147 +0x17c5
golang.org/x/tools/go/ssa.(*builder).stmtList(0xc003a7b140?, 0xc00317f5e8?, {0xc001031700?, 0x8, 0x8c9cc8?})
        /home/ldez/sources/go/pkg/mod/golang.org/x/[email protected]/go/ssa/builder.go:946 +0x45
golang.org/x/tools/go/ssa.(*builder).stmt(0xc0038a7800?, 0xc0038a7800, {0x1999770?, 0xc001201380?})
        /home/ldez/sources/go/pkg/mod/golang.org/x/[email protected]/go/ssa/builder.go:2277 +0x859
golang.org/x/tools/go/ssa.(*builder).buildFunctionBody(0xea2bd1?, 0xc0038a7800)
        /home/ldez/sources/go/pkg/mod/golang.org/x/[email protected]/go/ssa/builder.go:2391 +0x437
golang.org/x/tools/go/ssa.(*builder).buildFunction(0xea2c20?, 0xc0038a7800)
        /home/ldez/sources/go/pkg/mod/golang.org/x/[email protected]/go/ssa/builder.go:2326 +0x2e
golang.org/x/tools/go/ssa.(*builder).buildCreated(0xc00317fa38)
        /home/ldez/sources/go/pkg/mod/golang.org/x/[email protected]/go/ssa/builder.go:2413 +0x25
golang.org/x/tools/go/ssa.(*Package).build(0xc003880580)
        /home/ldez/sources/go/pkg/mod/golang.org/x/[email protected]/go/ssa/builder.go:2606 +0xc86
sync.(*Once).doSlow(0xc001fb6300?, 0xc00180ca50?)
        /usr/lib/go/src/sync/once.go:74 +0xc2
sync.(*Once).Do(...)
        /usr/lib/go/src/sync/once.go:65
golang.org/x/tools/go/ssa.(*Package).Build(...)
        /home/ldez/sources/go/pkg/mod/golang.org/x/[email protected]/go/ssa/builder.go:2477
golang.org/x/tools/go/analysis/passes/buildssa.run(0xc0021c0870)
        /home/ldez/sources/go/pkg/mod/golang.org/x/[email protected]/go/analysis/passes/buildssa/buildssa.go:72 +0x1a8
github.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*action).analyze(0xc001370630)
        /home/ldez/sources/go/src/github.com/golangci/golangci-lint/pkg/golinters/goanalysis/runner_action.go:196 +0xa25
github.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*action).analyzeSafe.func2()
        /home/ldez/sources/go/src/github.com/golangci/golangci-lint/pkg/golinters/goanalysis/runner_action.go:114 +0x1d
github.com/golangci/golangci-lint/pkg/timeutils.(*Stopwatch).TrackStage(0xc0012f57c0, {0x17326f6, 0x8}, 0xc0015b7748)
        /home/ldez/sources/go/src/github.com/golangci/golangci-lint/pkg/timeutils/stopwatch.go:111 +0x4a
github.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*action).analyzeSafe(0xc000f09320?)
        /home/ldez/sources/go/src/github.com/golangci/golangci-lint/pkg/golinters/goanalysis/runner_action.go:113 +0x85
github.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*loadingPackage).analyze.func2(0xc001370630)
        /home/ldez/sources/go/src/github.com/golangci/golangci-lint/pkg/golinters/goanalysis/runner_loadingpackage.go:80 +0xb4
created by github.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*loadingPackage).analyze
        /home/ldez/sources/go/src/github.com/golangci/golangci-lint/pkg/golinters/goanalysis/runner_loadingpackage.go:75 +0x208 
ERRO [runner] Panic: bodyclose: package "ent" (isInitialPkg: true, needAnalyzeSource: true): interface conversion: interface {} is nil, not *buildssa.SSA: goroutine 256 [running]:
runtime/debug.Stack()
        /usr/lib/go/src/runtime/debug/stack.go:24 +0x65
github.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*action).analyzeSafe.func1()
        /home/ldez/sources/go/src/github.com/golangci/golangci-lint/pkg/golinters/goanalysis/runner_action.go:110 +0x23c
panic({0x15e6880, 0xc0019b0060})
        /usr/lib/go/src/runtime/panic.go:884 +0x213
github.com/timakin/bodyclose/passes/bodyclose.runner.run({0xc00330c000, {0x0, 0x0}, 0x0, {0x0, 0x0}, 0x0, 0x0}, 0xc00330c000)
        /home/ldez/sources/go/pkg/mod/github.com/timakin/[email protected]/passes/bodyclose/bodyclose.go:45 +0x665
github.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*action).analyze(0xc0013705a0)
        /home/ldez/sources/go/src/github.com/golangci/golangci-lint/pkg/golinters/goanalysis/runner_action.go:196 +0xa25
github.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*action).analyzeSafe.func2()
        /home/ldez/sources/go/src/github.com/golangci/golangci-lint/pkg/golinters/goanalysis/runner_action.go:114 +0x1d
github.com/golangci/golangci-lint/pkg/timeutils.(*Stopwatch).TrackStage(0xc0012f57c0, {0x1741351, 0x9}, 0xc000117748)
        /home/ldez/sources/go/src/github.com/golangci/golangci-lint/pkg/timeutils/stopwatch.go:111 +0x4a
github.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*action).analyzeSafe(0xc000f09320?)
        /home/ldez/sources/go/src/github.com/golangci/golangci-lint/pkg/golinters/goanalysis/runner_action.go:113 +0x85
github.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*loadingPackage).analyze.func2(0xc0013705a0)
        /home/ldez/sources/go/src/github.com/golangci/golangci-lint/pkg/golinters/goanalysis/runner_loadingpackage.go:80 +0xb4
created by github.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*loadingPackage).analyze
        /home/ldez/sources/go/src/github.com/golangci/golangci-lint/pkg/golinters/goanalysis/runner_loadingpackage.go:75 +0x208 
WARN [runner] Can't run linter bodyclose: bodyclose: bodyclose: package "ent" (isInitialPkg: true, needAnalyzeSource: true): interface conversion: interface {} is nil, not *buildssa.SSA 
ERRO Running error: 1 error occurred:
        * can't run linter bodyclose: bodyclose: bodyclose: package "ent" (isInitialPkg: true, needAnalyzeSource: true): interface conversion: interface {} is nil, not *buildssa.SSA

Antonboom

like!
but log duplication for high-level-linter's panic doesn't look good 😞

pkg/golinters/goanalysis/runner_action.go

Co-authored-by: Anton Telyshev <[email protected]>

Antonboom

🔥

ldez added the bug Something isn't working label Mar 19, 2023

ldez mentioned this pull request Mar 19, 2023

bodyclose: panic "interface conversion: interface {} is nil, not *buildssa.SSA" #3086

Closed

4 tasks

ldez requested review from Antonboom and bombsimon March 19, 2023 18:38

ldez force-pushed the fix/improve-builssa-panic branch 3 times, most recently from 30dd25e to ddd76ca Compare March 19, 2023 18:46

fix: improve panic management

7e1a0f1

ldez force-pushed the fix/improve-builssa-panic branch from ddd76ca to 7e1a0f1 Compare March 19, 2023 18:46

Antonboom approved these changes Mar 19, 2023

View reviewed changes

pkg/golinters/goanalysis/runner_action.go Outdated Show resolved Hide resolved

pkg/golinters/goanalysis/runner_action.go Outdated Show resolved Hide resolved

ldez and others added 2 commits March 19, 2023 21:58

Apply suggestions from code review

f9e9726

Co-authored-by: Anton Telyshev <[email protected]>

fix: log only if not root analyzer

ea36e34

ldez force-pushed the fix/improve-builssa-panic branch from 746a16a to ea36e34 Compare March 19, 2023 21:13

Antonboom approved these changes Mar 19, 2023

View reviewed changes

ldez merged commit 076f6b9 into golangci:master Mar 19, 2023

ldez deleted the fix/improve-builssa-panic branch March 19, 2023 22:02

SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023

fix: improve panic management (golangci#3710)

ad18215

Antonboom mentioned this pull request Apr 12, 2023

Using a less advanced version of generic ent/ent#3463

Closed

ldez added this to the v1.52 milestone Mar 6, 2024

alexandear mentioned this pull request Mar 15, 2024

docs fix broken links alexandear-org/golangci-lint#1

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: improve panic management #3710

fix: improve panic management #3710

ldez commented Mar 19, 2023 •

edited

Loading

Antonboom left a comment •

edited

Loading

Antonboom left a comment

fix: improve panic management #3710

fix: improve panic management #3710

Conversation

ldez commented Mar 19, 2023 • edited Loading

Antonboom left a comment • edited Loading

Choose a reason for hiding this comment

Antonboom left a comment

Choose a reason for hiding this comment

ldez commented Mar 19, 2023 •

edited

Loading

Antonboom left a comment •

edited

Loading