-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: add TeamCity output format #3606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b48e731
to
cd2f633
Compare
cd2f633
to
d404923
Compare
This reverts commit e799af1.
Co-authored-by: Ludovic Fernandez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Did you test these changes on a TeamCity server? I did. And it doesn't work. My steps:
Output: "Code Inspection" tab is empty. You could view this directly on the TeamCity (use "Log in as guest"). |
Changes: - print SEVERITY; - populate inspectionType from linter's Name and Desc; - test escaping; - extend .golangci.reference.yml with TeamCity; - minor documentation fixes.
So, I pushed the commit f40b25d with fixes. Changes:
See here (use "Log in as guest"). |
No, and this is why I asked you to test it and why I didn't merge before your review.
I also asked you to not add commits to the PR. |
Ok, will do that in future PRs. Sorry, I didn't see the comment. Maybe because it was resolved and GitHub doesn't send notifications in such cases. |
Co-authored-by: Fernandez Ludovic <[email protected]> Co-authored-by: Oleksandr Redko <[email protected]>
fixes #3597