Skip to content

docs: update output example to use valid checkstyle example; add json example #3516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2023

Conversation

nickfiggins
Copy link
Contributor

the current example listed for outputs leads to checkstyle XML being saved to a .json file, which is a bit confusing since the output is xml. this PR updates the example to use xml for the checkstyle report, and send json to stdout to still show those capabilities

@boring-cyborg
Copy link

boring-cyborg bot commented Jan 28, 2023

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Jan 28, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez enabled auto-merge (squash) January 29, 2023 14:18
@ldez ldez merged commit 483ee1c into golangci:master Jan 29, 2023
SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
@ldez ldez added this to the v1.51 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants