Skip to content

dev: fix output tests #3118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2022
Merged

dev: fix output tests #3118

merged 1 commit into from
Aug 21, 2022

Conversation

ldez
Copy link
Member

@ldez ldez commented Aug 20, 2022

When a new linter is added, the output changes, so we cannot match the full report.
We have to focus on the Issues section.

@ldez ldez added bug Something isn't working area: tests Continuous integration, tests and other checks labels Aug 20, 2022
@ldez ldez mentioned this pull request Aug 21, 2022
Merged
@ldez ldez force-pushed the fix/output-tests branch from 605841f to 2708511 Compare August 21, 2022 00:14
bombsimon
bombsimon approved these changes Aug 21, 2022
View reviewed changes
Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

What I was thinking with my comment regarding matching more than the prefix was to actually unmarshal and check for the Issues key but since that's done in a different test this seems reasonable

@ldez ldez merged commit 4160e8c into golangci:master Aug 21, 2022
@ldez ldez deleted the fix/output-tests branch August 21, 2022 11:30
SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
@ldez @SeigeC
dev: fix output tests (golangci#3118)
363be77
@ldez ldez added this to the v1.49 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bombsimon bombsimon bombsimon approved these changes

Assignees
No one assigned
Labels
area: tests Continuous integration, tests and other checks bug Something isn't working
Projects
None yet
Milestone
v1.49
Development

Successfully merging this pull request may close these issues.
2 participants
@ldez @bombsimon