docs: add a section about default exclusions #3117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bombsimon
approved these changes
Aug 20, 2022
There was a problem hiding this comment.
LGTM
I know there's been quite some issues on this topic and different opinions (f.ex. #456 and #2239). There have been comments in such issues that this cannot be changed in a v1 due to breaking changes but that there are plans to change this in v2. Do you think it's worth mentioning any of that to avoid additional issues or will it just risk getting forgotten and get outdated?
For now, it's not really useful. I already started to think about the v2 and I think we will keep "suggested" exclusions but not by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preview