Skip to content

runAnalyzersConfig: export analyzers #2710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

runAnalyzersConfig: export analyzers #2710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/golinters/goanalysis/linter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ func (lnt *Linter) getLinterNameForDiagnostic(*Diagnostic) string {
return lnt.name
}

func (lnt *Linter) getAnalyzers() []*analysis.Analyzer {
func (lnt *Linter) GetAnalyzers() []*analysis.Analyzer {
return lnt.analyzers
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/golinters/goanalysis/metalinter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ func (ml MetaLinter) getLoadMode() LoadMode {
return loadMode
}

func (ml MetaLinter) getAnalyzers() []*analysis.Analyzer {
func (ml MetaLinter) GetAnalyzers() []*analysis.Analyzer {
var allAnalyzers []*analysis.Analyzer
for _, l := range ml.linters {
allAnalyzers = append(allAnalyzers, l.analyzers...)
Expand Down
8 changes: 4 additions & 4 deletions pkg/golinters/goanalysis/runners.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import (
type runAnalyzersConfig interface {
getName() string
getLinterNameForDiagnostic(*Diagnostic) string
getAnalyzers() []*analysis.Analyzer
GetAnalyzers() []*analysis.Analyzer
useOriginalPackages() bool
reportIssues(*linter.Context) []Issue
getLoadMode() LoadMode
Expand All @@ -41,21 +41,21 @@ func runAnalyzers(cfg runAnalyzersConfig, lintCtx *linter.Context) ([]result.Iss
pkgs = lintCtx.OriginalPackages
}

issues, pkgsFromCache := loadIssuesFromCache(pkgs, lintCtx, cfg.getAnalyzers())
issues, pkgsFromCache := loadIssuesFromCache(pkgs, lintCtx, cfg.GetAnalyzers())
var pkgsToAnalyze []*packages.Package
for _, pkg := range pkgs {
if !pkgsFromCache[pkg] {
pkgsToAnalyze = append(pkgsToAnalyze, pkg)
}
}

diags, errs, passToPkg := runner.run(cfg.getAnalyzers(), pkgsToAnalyze)
diags, errs, passToPkg := runner.run(cfg.GetAnalyzers(), pkgsToAnalyze)

defer func() {
if len(errs) == 0 {
// If we try to save to cache even if we have compilation errors
// we won't see them on repeated runs.
saveIssuesToCache(pkgs, pkgsFromCache, issues, lintCtx, cfg.getAnalyzers())
saveIssuesToCache(pkgs, pkgsFromCache, issues, lintCtx, cfg.GetAnalyzers())
}
}()

Expand Down