Use upstream version of prealloc #1694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The forked version of prealloc at github.com/golangci/prealloc has not been kept up to date with the latest changes from the upstream repository, github.com/alexkohler/prealloc. This takes advantage of a recent refactor in the upstream to allow importing the logic directly as a package, which allows golangci to remove the overhead of maintaining a fork while effectively bumping the version of prealloc used. Fixes golangci#991
|
Hey, thank you for opening your first Pull Request ! |
|
|
|
Hey, @rliebz — we just merged your PR to
By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests. Thanks again! |
ashanbrown
pushed a commit
to ashanbrown/golangci-lint
that referenced
this pull request
Feb 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The forked version of prealloc at github.com/golangci/prealloc has not
been kept up to date with the latest changes from the upstream
repository, github.com/alexkohler/prealloc. This takes advantage of a
recent refactor in the upstream to allow importing the logic directly as
a package, which allows golangci to remove the overhead of maintaining a
fork while effectively bumping the version of prealloc used.
Fixes #991