Skip to content

Expose more config options for forbidigo #1677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 1, 2021

Conversation

ashanbrown
Copy link
Contributor

@ashanbrown ashanbrown commented Feb 1, 2021

The latest version of forbidigo excludes godoc examples by default. This PR adds a config option to disable that feature if so desired. Forbidigo now also allows us to ignore its own //permit nolint directive in favor of //nolint. I don't think it makes sense to have multiple ways of ignore errors.

@ldez
Copy link
Member

ldez commented Feb 1, 2021

#1678

@ashanbrown ashanbrown changed the title Upgrade forbidigo Expose more config options for forbidigo Feb 1, 2021
@ashanbrown ashanbrown marked this pull request as ready for review February 1, 2021 15:55
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 9e0c9f3 into golangci:master Feb 1, 2021
@ldez ldez added enhancement New feature or improvement linter: update version Update version of linter and removed enhancement New feature or improvement labels Feb 1, 2021
ashanbrown added a commit to ashanbrown/golangci-lint that referenced this pull request Feb 20, 2021
@ldez ldez added this to the v1.37 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter: update version Update version of linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants