Using upstream dupl #1552
Closed
Using upstream dupl #1552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nivl
reviewed
Dec 13, 2020
There was a problem hiding this comment.
My main concern here is that we're not removing a fork, we're switching from our own (outdated) fork to yours.
I think we should wait for mibk/dupl#18 to get merged upstream before doing anything (which might be the reason why you put the PR back as Draft after requesting a review?).
|
@Nivl, yes this is why PR is in draft. If the dupl PR is not merged then there is no point in swapping a fork for another one :) |
|
I will close this PR for now because #1551 already tracks this topic. And the PR mibk/dupl#18 is opened for more than a year. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1551.
See: mibk/dupl#18.