Skip to content

build(dep): Ignore known dependency failure in nancy #1378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2020
Merged

build(dep): Ignore known dependency failure in nancy #1378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/pr-extra.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
steps:
- uses: actions/checkout@v2
- uses: actions/setup-go@v2
# We cannot use nancy-github-action because it is outdated, so it's better to use the latest
# docker image for the validation
- name: nancy
run: go list -json -m all | docker run -i sonatypecommunity/nancy:v0.3
- name: Run go list
run: go list -json -m all > go.list
- name: Nancy
uses: sonatype-nexus-community/nancy-github-action@master
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to github action as it's updated to the latest now, another benefit is that we don't need to mount volume for .nancy-ignore file.

11 changes: 11 additions & 0 deletions .nancy-ignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# Skip for golang/golang.org/x/[email protected]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latest x/net package is still having some vulnerbilities

CVE-2018-17848
CVE-2018-17143
CVE-2018-17847
CVE-2018-17142
CVE-2018-17846

# Skip for indirect dependency github.com/coreos/[email protected]
CVE-2020-15114
CVE-2020-15115
CVE-2020-15136