fix invalid error message "no go files to analyze" #1154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwankgb
requested changes
May 18, 2020
| // Currently, go/packages doesn't guarantee that error will be returned | ||
| // if context was cancelled. See | ||
| // https://github.com/golang/tools/commit/c5cec6710e927457c3c29d6c156415e8539a5111#r39261855 | ||
| if ctx.Err() != nil { |
There was a problem hiding this comment.
Perhaps:
if err := ctx.Err(); err != nil {would do? It would allow to avoid calling ctx.Err() twice.
There was a problem hiding this comment.
I don't see any profit to save nanoseconds here :)
There was a problem hiding this comment.
update: maybe microseconds
func (c *cancelCtx) Err() error {
c.mu.Lock()
err := c.err
c.mu.Unlock()
return err
}It doesn't make sense to waste time on such micro-optimization, there are a lot of things to save seconds of time
ryancurrah
reviewed
May 18, 2020
pkg/lint/load.go
Outdated
| // if context was cancelled. See | ||
| // https://github.com/golang/tools/commit/c5cec6710e927457c3c29d6c156415e8539a5111#r39261855 | ||
| if ctx.Err() != nil { | ||
| return nil, errors.Wrap(ctx.Err(), "timeouted to load packages") |
In case of timeouts of go/packages loading we could return such error. Relates: #825
jirfag
force-pushed
the
feature/fix-no-go-files-to-analyze-on-timeout
branch
from
aa8137f to
d5f7501
Compare
iwankgb
approved these changes
May 19, 2020
delete-merged-branch
bot
deleted the
feature/fix-no-go-files-to-analyze-on-timeout
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of timeouts of go/packages loading
we could return such error.
Relates: #825