Skip to content

golangci-lint.sh: crit uname_os_check 'MINGW64_NT-10.0' got converted to 'mingw64_nt-10.0' which is not a GOOS value #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mholt opened this issue Mar 30, 2019 · 3 comments · Fixed by #525
Closed

golangci-lint.sh: crit uname_os_check 'MINGW64_NT-10.0' got converted to 'mingw64_nt-10.0' which is not a GOOS value #472

mholt opened this issue Mar 30, 2019 · 3 comments · Fixed by #525

Comments

@mholt
Copy link

mholt commented Mar 30, 2019 •
edited
Loading

Running the install script on Azure Pipelines (Windows) returns this error:

golangci/golangci-lint crit uname_os_check 'MINGW64_NT-10.0' got converted to 'mingw64_nt-10.0' which is not a GOOS value. Please file bug at https://github.com/client9/shlib

I know it says to file a bug over in shlib, but similar issues are unresolved, and this code lives in this repo anyway, not shlib.

Would be nice to have this work, as writing more platform-specific code to install a go program doesn't sound awesome. I'll probably just fall back to using go get for now.

Update: Fortunately the go get works! Any idea why it is not recommended? Seems much simpler...
@mholt mholt mentioned this issue Mar 30, 2019
Merged
@jirfag
Copy link
Contributor

jirfag commented Apr 20, 2019

Hi!
Sorry, I have no Windows for testing. It would be ok if you locally fix it in the golangci-lint repo. Pull requests are welcome

@mholt
Copy link
Author

mholt commented Apr 20, 2019

I don't have Windows either 😅

AlekSi added a commit to AlekSi/golangci-lint that referenced this issue Apr 30, 2019
@AlekSi
Make install script work on Windows.
2187602 
Closes golangci#472.
@AlekSi
Copy link
Contributor

AlekSi commented Apr 30, 2019

Any idea why it is not recommended?

Because (without modules) go get -u installs the version from master branch, not the latest tagged release.

@AlekSi AlekSi mentioned this issue Apr 30, 2019
Merged
jirfag pushed a commit that referenced this issue Jun 9, 2019
@AlekSi @jirfag
Make install script work on Windows.
778888a 
Closes #472.
@mxpv mxpv mentioned this issue Jul 15, 2019
Closed
@snyk-bot snyk-bot mentioned this issue Sep 21, 2021
Open
@snyk-bot snyk-bot mentioned this issue Dec 2, 2021
Open
@snyk-bot snyk-bot mentioned this issue Jan 30, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make install script work on Windows. AlekSi/golangci-lint
3 participants
@AlekSi @mholt @jirfag