Skip to content

nolint comments are not working #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dvyukov opened this issue Mar 28, 2019 · 2 comments
Closed

nolint comments are not working #468

dvyukov opened this issue Mar 28, 2019 · 2 comments
Labels
area: cgo Related to CGO or line directives area: nolint Related to nolint directive and nolintlint bug Something isn't working

Comments

@dvyukov
Copy link

dvyukov commented Mar 28, 2019

//nolint comments are not working, I am getting:

pkg/ifuzz/decode.go:13:1: cyclomatic complexity 75 of func `Decode` is high (> 24) (gocyclo)
func Decode(mode int, text []byte) (int, error) { //nolint:gocyclo

golangci-lint has version v1.15.0-21-gf516771 built from f516771 on Thu Mar 28 14:06:02 CET 2019
@dvyukov dvyukov mentioned this issue Mar 28, 2019
Closed
jirfag added a commit that referenced this issue Apr 20, 2019
@jirfag
Fix linting of preprocessed files
c677366 
Preprocessed files like .qtpl.go quicktemplate Go files can have
//line directives. They map to a source .qtpl file.
This commit fixes linting of such files:
1. don't fail on AST cache loading
2. output Go filename not .qtpl or similar

Also, here we update golint to the upstream version.

Relates: #316, #466, #467, #468
@jirfag jirfag mentioned this issue Apr 20, 2019
Merged
jirfag added a commit that referenced this issue Apr 20, 2019
@jirfag
Fix linting of preprocessed files
397ba7f 
Preprocessed files like .qtpl.go quicktemplate Go files can have
//line directives. They map to a source .qtpl file.
This commit fixes linting of such files:
1. don't fail on AST cache loading
2. output Go filename not .qtpl or similar

Also, here we update golint to the upstream version.

Relates: #316, #466, #467, #468
jirfag added a commit that referenced this issue Apr 20, 2019
@jirfag
Fix linting of preprocessed files
ed0b551 
Preprocessed files like .qtpl.go quicktemplate Go files can have
//line directives. They map to a source .qtpl file.
This commit fixes linting of such files:
1. don't fail on AST cache loading
2. output Go filename not .qtpl or similar

Also, here we update golint to the upstream version.

Relates: #316, #466, #467, #468
jirfag added a commit that referenced this issue Apr 20, 2019
@jirfag
Fix linting of goyacc files
b09af54 
Skip yacctab, yaccpar and NONE files.

Relates: #467, #468
@jirfag jirfag mentioned this issue Apr 20, 2019
Merged
@jirfag
Copy link
Contributor

jirfag commented Apr 20, 2019

Hi, thank you!
The issue was because of poor .rl and .y files support. I've fixed it in #504 and #505.

I've run golangci-lint on the github.com/google/syzkaller: gocyclo doesn't report about pkg/ifuzz/decode.go.

jirfag added a commit that referenced this issue Apr 20, 2019
@jirfag
Fix linting of goyacc files
ec5bf9b 
Skip yacctab, yaccpar and NONE files.

Relates: #467, #468
@dvyukov
Copy link
Author

dvyukov commented Apr 23, 2019

Now everything seems to work as expected. Thanks!

@dvyukov dvyukov closed this as completed Apr 23, 2019
@snyk-bot snyk-bot mentioned this issue Sep 21, 2021
Open
@snyk-bot snyk-bot mentioned this issue Dec 2, 2021
Open
@snyk-bot snyk-bot mentioned this issue Jan 30, 2022
Open
@ldez ldez added bug Something isn't working area: nolint Related to nolint directive and nolintlint labels Mar 24, 2024
@ldez ldez added the area: cgo Related to CGO or line directives label Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: cgo Related to CGO or line directives area: nolint Related to nolint directive and nolintlint bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dvyukov @jirfag @ldez