Skip to content

Update gosec linter #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nikjain0594 opened this issue Apr 30, 2020 · 2 comments · Fixed by #1062
Closed

Update gosec linter #1052

nikjain0594 opened this issue Apr 30, 2020 · 2 comments · Fixed by #1062
Labels
linter: update version Update version of linter

Comments

@nikjain0594
Copy link

Hi There,

Gosec has released v2 version and there are many updates in code, can we please update golangci-lint code to support v2 version of gosec.

Thanks in advance.

Regards,
Nikhil
@ernado ernado added the linter: update version Update version of linter label Apr 30, 2020
@ernado
Copy link
Member

ernado commented Apr 30, 2020

Thank you for report.

Seems like there were breaking changes in API, so it is not a trivial update and PR is welcome.

theckman added a commit to theckman/golangci-lint that referenced this issue May 3, 2020
@theckman
Update gosec linter to v2
e2f21f2 
This change updates the `gosec` linter to its v2 version. It seems like v2
maintained API compatibility for the functionality we use, so we only needed to
update the dependency and imports.

Please note, this does not use a tagged version of `gosec` and instead is the
latest `master` commit due to this issue: securego/gosec#470.
Once this issue is resolved we should update `gosec` to a tagged release.

Fixes golangci#1052
theckman added a commit to theckman/golangci-lint that referenced this issue May 3, 2020
@theckman
Update gosec linter to v2; add .test files to .gitignore
ad815d7 
This change updates the `gosec` linter to its v2 version. It seems like v2
maintained API compatibility for the functionality we use, so we only needed to
update the dependency and imports.

Please note, this does not use a tagged version of `gosec` and instead is the
latest `master` commit due to this issue: securego/gosec#470.
Once this issue is resolved we should update `gosec` to a tagged release.

This also adds a line to the `.gitignore` file, to ignore the `.test` output
files that get generated by `go test`. This could accidentally get left behind,
so no use committing binary files.

Fixes golangci#1052
@theckman theckman mentioned this issue May 3, 2020
Merged
@theckman
Copy link
Contributor

theckman commented May 3, 2020

@ernado doesn't seem like they broke any of the APIs we use, but their repo is in a bit of a broken state (securego/gosec#470). I raised #1062 to get gosec updated, but because of that issue I linked it's not able to use a tagged release.

theckman added a commit to theckman/golangci-lint that referenced this issue May 3, 2020
@theckman
Update gosec linter to v2; add .test files to .gitignore
48ee237 
This change updates the `gosec` linter to its v2 version. It seems like v2
maintained API compatibility for the functionality we use, so we only needed to
update the dependency and imports.

Please note, this does not use a tagged version of `gosec` and instead is the
latest `master` commit due to this issue: securego/gosec#470.
Once this issue is resolved we should update `gosec` to a tagged release.

This also adds a line to the `.gitignore` file, to ignore the `.test` output
files that get generated by `go test`. This could accidentally get left behind,
so no use committing binary files.

Fixes golangci#1052
jirfag pushed a commit that referenced this issue May 3, 2020
@theckman
Update gosec linter to v2; add .test files to .gitignore (#1062)
60fd647 
This change updates the `gosec` linter to its v2 version. It seems like v2
maintained API compatibility for the functionality we use, so we only needed to
update the dependency and imports.

Please note, this does not use a tagged version of `gosec` and instead is the
latest `master` commit due to this issue: securego/gosec#470.
Once this issue is resolved we should update `gosec` to a tagged release.

This also adds a line to the `.gitignore` file, to ignore the `.test` output
files that get generated by `go test`. This could accidentally get left behind,
so no use committing binary files.

Fixes #1052
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
linter: update version Update version of linter
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update gosec linter to v2; add .test files to .gitignore theckman/golangci-lint
3 participants
@theckman @ernado @nikjain0594