dev: linting and factorization

Author: ldez

scripts/bench/bench_local.sh

@@ -13,18 +13,18 @@ VERSION=$2
 
 function cleanBinaries() {
   echo "Clean binaries"
-  rm ./golangci-lint-${VERSION}
+  rm "./golangci-lint-${VERSION}"
   rm ./golangci-lint
 }
 
 trap cleanBinaries EXIT
 
 ## Download version
 
-curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b ./temp-${VERSION}/ ${VERSION}
+curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b "./temp-${VERSION}" "${VERSION}"
 
-mv temp-${VERSION}/golangci-lint ./golangci-lint-${VERSION}
-rm -rf temp-${VERSION}
+mv "temp-${VERSION}/golangci-lint" "./golangci-lint-${VERSION}"
+rm -rf "temp-${VERSION}"
 
 ## Build local version
 
@@ -38,4 +38,4 @@ hyperfine \
 
 ## Clean
 
-rm ./golangci-lint-${VERSION}
+rm "./golangci-lint-${VERSION}"

scripts/bench/bench_version.sh

@@ -15,25 +15,30 @@ VERSION_NEW="$3"
 
 function cleanBinaries() {
   echo "Clean binaries"
-  rm ./golangci-lint-${VERSION_OLD}
-  rm ./golangci-lint-${VERSION_NEW}
+  rm "./golangci-lint-${VERSION_OLD}"
+  rm "./golangci-lint-${VERSION_NEW}"
 }
 
 trap cleanBinaries EXIT
 
-## VERSION_OLD
+## Install
 
-curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b ./temp-${VERSION_OLD} ${VERSION_OLD}
+function install() {
+  local VERSION=$1
 
-mv temp-${VERSION_OLD}/golangci-lint ./golangci-lint-${VERSION_OLD}
-rm -rf temp-${VERSION_OLD}
+  curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b "./temp-${VERSION}" "${VERSION}"
 
-## VERSION_NEW
+  mv "temp-${VERSION}/golangci-lint" "./golangci-lint-${VERSION}"
+  rm -rf "temp-${VERSION}"
+}
 
-curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b ./temp-${VERSION_NEW} ${VERSION_NEW}
+## VERSION_OLD
+
+install "${VERSION_OLD}"
+
+## VERSION_NEW
 
-mv temp-${VERSION_NEW}/golangci-lint ./golangci-lint-${VERSION_NEW}
-rm -rf temp-${VERSION_NEW}
+install "${VERSION_NEW}"
 
 ## Run