dev: naming and trap

Author: ldez

scripts/bench/bench_local.sh

@@ -4,17 +4,27 @@
 # Usage: ./scripts/bench/bench_local.sh gosec v1.59.0
 
 # ex: gosec
-LINTER_NAME=$1
+LINTER=$1
 
 # ex: v1.59.0
-GCIL_VERSION=$2
+VERSION=$2
+
+## Clean
+
+function cleanBinaries() {
+  echo "Clean binaries"
+  rm ./golangci-lint-${VERSION}
+  rm ./golangci-lint
+}
+
+trap cleanBinaries EXIT
 
 ## Download version
 
-curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b ./temp-${GCIL_VERSION}/ ${GCIL_VERSION}
+curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b ./temp-${VERSION}/ ${VERSION}
 
-mv temp-${GCIL_VERSION}/golangci-lint ./golangci-lint-${GCIL_VERSION}
-rm -rf temp-${GCIL_VERSION}
+mv temp-${VERSION}/golangci-lint ./golangci-lint-${VERSION}
+rm -rf temp-${VERSION}
 
 ## Build local version
 
@@ -23,9 +33,9 @@ make build
 ## Run
 
 hyperfine \
---prepare 'golangci-lint cache clean' "./golangci-lint run --print-issued-lines=false --enable-only ${LINTER_NAME}" \
---prepare './golangci-lint cache clean' "./golangci-lint-${GCIL_VERSION} run --print-issued-lines=false --enable-only ${LINTER_NAME}"
+--prepare 'golangci-lint cache clean' "./golangci-lint run --print-issued-lines=false --enable-only ${LINTER}" \
+--prepare './golangci-lint cache clean' "./golangci-lint-${VERSION} run --print-issued-lines=false --enable-only ${LINTER}"
 
 ## Clean
 
-rm ./golangci-lint-${GCIL_VERSION}
+rm ./golangci-lint-${VERSION}

scripts/bench/bench_version.sh

@@ -4,34 +4,39 @@
 # Usage: ./scripts/bench/bench_version.sh gosec v1.58.1 v1.58.2
 
 # ex: gosec
-LINTER_NAME=$1
+LINTER="$1"
 
 # ex: v1.58.1
-GCIL_VERSION_ONE=$2
+VERSION_OLD="$2"
 # ex: v1.58.2
-GCIL_VERSION_TWO=$3
+VERSION_NEW="$3"
 
-## GCIL_VERSION_ONE
+## Clean
 
-curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b ./temp-${GCIL_VERSION_ONE} ${GCIL_VERSION_ONE}
+function cleanBinaries() {
+  echo "Clean binaries"
+  rm ./golangci-lint-${VERSION_OLD}
+  rm ./golangci-lint-${VERSION_NEW}
+}
 
-mv temp-${GCIL_VERSION_ONE}/golangci-lint ./golangci-lint-${GCIL_VERSION_ONE}
-rm -rf temp-${GCIL_VERSION_ONE}
+trap cleanBinaries EXIT
 
-## GCIL_VERSION_TWO
+## VERSION_OLD
 
-curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b ./temp-${GCIL_VERSION_TWO} ${GCIL_VERSION_TWO}
+curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b ./temp-${VERSION_OLD} ${VERSION_OLD}
 
-mv temp-${GCIL_VERSION_TWO}/golangci-lint ./golangci-lint-${GCIL_VERSION_TWO}
-rm -rf temp-${GCIL_VERSION_TWO}
+mv temp-${VERSION_OLD}/golangci-lint ./golangci-lint-${VERSION_OLD}
+rm -rf temp-${VERSION_OLD}
 
-## Run
+## VERSION_NEW
 
-hyperfine \
---prepare 'golangci-lint cache clean' "./golangci-lint-${GCIL_VERSION_ONE} run --issues-exit-code 0 --print-issued-lines=false --enable-only ${LINTER_NAME}" \
---prepare './golangci-lint cache clean' "./golangci-lint-${GCIL_VERSION_TWO} run --issues-exit-code 0 --print-issued-lines=false --enable-only ${LINTER_NAME}"
+curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b ./temp-${VERSION_NEW} ${VERSION_NEW}
 
-## Clean
+mv temp-${VERSION_NEW}/golangci-lint ./golangci-lint-${VERSION_NEW}
+rm -rf temp-${VERSION_NEW}
 
-rm ./golangci-lint-${GCIL_VERSION_ONE}
-rm ./golangci-lint-${GCIL_VERSION_TWO}
+## Run
+
+hyperfine \
+--prepare 'golangci-lint cache clean' "./golangci-lint-${VERSION_OLD} run --issues-exit-code 0 --print-issued-lines=false --enable-only ${LINTER}" \
+--prepare './golangci-lint cache clean' "./golangci-lint-${VERSION_NEW} run --issues-exit-code 0 --print-issued-lines=false --enable-only ${LINTER}"