fix: get correct home dir on Windows #1069
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
requested changes
Jul 2, 2024
| return path.resolve(`${process.env.HOME}/.cache/golangci-lint`) | ||
| const home = process.platform === "win32" ? "USERPROFILE" : "HOME" | ||
|
|
||
| return path.resolve(`${home}/.cache/golangci-lint`) |
There was a problem hiding this comment.
this will just use the path HOME/.cache/golangci-lint not the value of env var.
|
As the PR comes from a fork inside a GitHub organization, I cannot edit it, so I close it and open another one. I recommend not using a GitHub organization to create PR, this is a problem with automation and maintainer modifications. Edit: fixed in 2c01d26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.