Skip to content

Add a warning when using too old golangci version #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
moul opened this issue Jul 12, 2020 · 0 comments · Fixed by #40
Closed

Add a warning when using too old golangci version #37

moul opened this issue Jul 12, 2020 · 0 comments · Fixed by #40
Assignees
@SVilgelm
Labels
bug Something isn't working

Comments

@moul
Copy link

moul commented Jul 12, 2020

The last release (#34) brakes all the projects using golangci-lint-action@v1 and version = v1.27 (easy fix -> bump at v1.28).

Example: moul/golang-repo-template#62

What do you think about adding a more explicit warning when the user's version is older than a minimal_supported_version constant you keep updated internally in this repo?
This was referenced Jul 12, 2020
Closed
Merged
This was referenced Jul 12, 2020
Merged
Merged
moul-bot pushed a commit to moul/repoman that referenced this issue Jul 12, 2020
@moul
fix: update golangci-lint
d758c8f 
see golangci/golangci-lint-action#37

Signed-off-by: Manfred Touron <[email protected]>
@moul moul mentioned this issue Jul 12, 2020
Merged
This was referenced Jul 12, 2020
Merged
Merged
Merged
@SVilgelm SVilgelm added the bug Something isn't working label Jul 14, 2020
@SVilgelm SVilgelm self-assigned this Jul 14, 2020
@SVilgelm SVilgelm mentioned this issue Jul 14, 2020
Merged
@SVilgelm SVilgelm linked a pull request Jul 14, 2020 that will close this issue
Prepare v2.0.0 #40
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SVilgelm SVilgelm

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prepare v2.0.0 golangci/golangci-lint-action
2 participants
@moul @SVilgelm