-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Added one more GCP connection string example for flexible environment. #993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Would you confirm an example in Standard 2nd example is OK? As far as I can see, Google uses
|
It is Go 1.9. It's 1st gen. It will be die soon. (No new deply since 2019-10-01) Go 1.11 and 1.12 are 2nd gen. It uses |
Yes, true, you're right! For 2nd gen: |
Please unify 2nd gen example and flexible example if they are same. |
Does it look better? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but travis fail blocks merging this.
Is it possible to me to do something with travis? |
No. I already made PR to fix it but I can not merge it. Only another maintainer can help. This project needs at least two active maintainers to go forward. Sorry. |
@cn007b could you please rebase your changes onto the current upstream master? |
Done. |
* Added GCP connection string example for flexible environment. * Added one more GCP connection string example for flexible environment. * Unified GCP connection strings examples for 2nd gen and flexible env.
* Added GCP connection string example for flexible environment. * Added one more GCP connection string example for flexible environment. * Unified GCP connection strings examples for 2nd gen and flexible env.
Description
Added one more GCP connection string example for flexible environment.
Checklist