Skip to content

fix appengine #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 10, 2019
Merged

fix appengine #950

merged 3 commits into from
Apr 10, 2019

Conversation

methane
Copy link
Member

@methane methane commented Apr 5, 2019 •
edited
Loading

Description

  • syscall package can not be used on AppEngine Standard.
  • "syscall" package is deprecated. Using deprecated "syscall" package is unavoidable for SyscallConn method.

Fixes #944

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

@methane methane mentioned this pull request Apr 5, 2019
Closed
shogo82148
shogo82148 approved these changes Apr 5, 2019
View reviewed changes
Copy link
Contributor

@shogo82148 shogo82148 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@methane
Copy link
Member Author

methane commented Apr 5, 2019

I'm not GAE user. I want someone confirm this works now.

@alexherns
Copy link

confirmed this worked for me

@methane methane merged commit 578c4c8 into go-sql-driver:master Apr 10, 2019
@methane methane deleted the appengine branch April 10, 2019 03:04
@methane
Copy link
Member Author

methane commented Apr 10, 2019

@alexherns Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shogo82148 shogo82148 shogo82148 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@methane @alexherns @shogo82148