Tests cleanup: close rows when done to avoid resource leak during testing #918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
methane
reviewed
Jan 25, 2019
driver_test.go
Outdated
| @@ -248,6 +249,7 @@ func TestCRUD(t *testing.T) { | |||
| if id != 0 { | |||
| dbt.Fatalf("expected InsertId 0, got %d", id) | |||
| } | |||
| rows.Close() | |||
methane
reviewed
Jan 25, 2019
driver_test.go
Outdated
| @@ -339,6 +343,7 @@ func TestMultiQuery(t *testing.T) { | |||
| // Read | |||
| var out int | |||
| rows := dbt.mustQuery("SELECT value FROM test WHERE id=1;") | |||
| defer rows.Close() | |||
There was a problem hiding this comment.
Don't use defer rows.Close() in loop.
driver_test.go
Outdated
| @@ -369,6 +374,7 @@ func TestInt(t *testing.T) { | |||
| dbt.mustExec("INSERT INTO test VALUES (?)", in) | |||
|
|
|||
| rows = dbt.mustQuery("SELECT value FROM test") | |||
| defer rows.Close() | |||
There was a problem hiding this comment.
Don't use defer rows.Close() in loop.
driver_test.go
Outdated
| @@ -388,6 +394,7 @@ func TestInt(t *testing.T) { | |||
| dbt.mustExec("INSERT INTO test VALUES (?)", in) | |||
|
|
|||
| rows = dbt.mustQuery("SELECT value FROM test") | |||
| defer rows.Close() | |||
driver_test.go
Outdated
| @@ -412,6 +419,7 @@ func TestFloat32(t *testing.T) { | |||
| dbt.mustExec("CREATE TABLE test (value " + v + ")") | |||
| dbt.mustExec("INSERT INTO test VALUES (?)", in) | |||
| rows = dbt.mustQuery("SELECT value FROM test") | |||
| defer rows.Close() | |||
driver_test.go
Outdated
| @@ -435,6 +443,7 @@ func TestFloat64(t *testing.T) { | |||
| dbt.mustExec("CREATE TABLE test (value " + v + ")") | |||
| dbt.mustExec("INSERT INTO test VALUES (42.23)") | |||
| rows = dbt.mustQuery("SELECT value FROM test") | |||
| defer rows.Close() | |||
driver_test.go
Outdated
| @@ -458,6 +467,7 @@ func TestFloat64Placeholder(t *testing.T) { | |||
| dbt.mustExec("CREATE TABLE test (id int, value " + v + ")") | |||
| dbt.mustExec("INSERT INTO test VALUES (1, 42.23)") | |||
| rows = dbt.mustQuery("SELECT value FROM test WHERE id = ?", 1) | |||
| defer rows.Close() | |||
driver_test.go
Outdated
| @@ -484,6 +494,7 @@ func TestString(t *testing.T) { | |||
| dbt.mustExec("INSERT INTO test VALUES (?)", in) | |||
|
|
|||
| rows = dbt.mustQuery("SELECT value FROM test") | |||
| defer rows.Close() | |||
|
@methane I took another stab at this PR:
|
methane
approved these changes
Jan 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close rows after we are done using them avoids having a bunch of connections hanging around.
Checklist