Skip to content

Fix caching_sha2_password with empty password #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2018
Merged

Fix caching_sha2_password with empty password #826

merged 1 commit into from
Jul 19, 2018

Conversation

methane
Copy link
Member

@methane methane commented Jul 2, 2018 •
edited
Loading

There shouldn't be trailing NUL byte for caching_sha2_password.

Fixes #825

Description

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

@methane
Fix caching_sha2_password with empty password
287a500 
There shouldn't be trailing NUL byte for caching_sha2_password.

Fixes go-sql-driver#825
@julienschmidt
Copy link
Member

Can you add a regression test for #825?
Besides that, I think we should release a bugfix release (1.4.1) for this and #835 when they're merged.

@julienschmidt julienschmidt added this to the v1.4.1 milestone Jul 13, 2018
@methane
Copy link
Member Author

methane commented Jul 13, 2018

Can you add a regression test for #825?

I fixed bug in test case too.

@julienschmidt
Copy link
Member

A bit OT: After this PR I would like to release a1.4.1 bugfix release. However, we dropped Go 1.7 support since the 1.4.0 release.
Should we create a branch and backport the fixes or just release 1.4.1 without Go 1.7 support?

@methane methane merged commit 99ff426 into go-sql-driver:master Jul 19, 2018
@methane methane deleted the caching-sha2-nopass branch July 19, 2018 07:19
@methane
Copy link
Member Author

methane commented Jul 19, 2018

By theory, we need to keep Go 1.7 support.

But I think real usage of Go 1.7 is very small.
GAE/Go is main motivation to support old Go.
But GAE/Go uses Go 1.6, 1.8, 1.9, but not 1.7.

julienschmidt pushed a commit that referenced this pull request Nov 14, 2018
@methane @julienschmidt
Fix caching_sha2_password with empty password (#826)
885c931 
There shouldn't be trailing NUL byte for caching_sha2_password.

Fixes #825
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienschmidt julienschmidt julienschmidt approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v1.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@methane @julienschmidt