Skip to content

implement SessionResetter. #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2018
Merged

implement SessionResetter. #779

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3593df
implement SessionResetter.
shogo82148 Apr 7, 2018
747d712
remove unhelpful log
shogo82148 Apr 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions connection_go18.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,3 +200,13 @@ func (mc *mysqlConn) CheckNamedValue(nv *driver.NamedValue) (err error) {
nv.Value, err = converter{}.ConvertValue(nv.Value)
return
}

// ResetSession implements driver.SessionResetter.
// (From Go 1.10)
func (mc *mysqlConn) ResetSession(ctx context.Context) error {
if mc.closed.IsSet() {
errLog.Print(ErrInvalidConn)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this log helpful?
Are there some scenarios which mc is closed but log is not printed yet?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it isn't.
I'll remove it.

return driver.ErrBadConn
}
return nil
}