Differentiate between BINARY and CHAR #724
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking up the database type name, we now check the character set
for the following field types:
If the character set is 63 (which is the binary pseudo character set),
we return the binary names, which are (respectively):
If any other character set is in use, we return the text names, which
are (again, respectively):
To facilitate this, mysqlField has been extended to include a uint8
field for character set, which is read from the appropriate packet.
Column type tests have been updated to ensure coverage of binary and
text types.
Description
This is a pull request to support differentiating between BINARY and CHAR, as discussed under issue #723.
Checklist