Fix tls=true didn't work with host without port. #718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
methane
force-pushed
the
fix-717-tls-hostport
branch
from
04e90ad to
c5207bc
Compare
julienschmidt
approved these changes
Dec 4, 2017
|
Looks like this change has not made it into a release yet, since the last release was in 2016. Any plans to cut a release? (if not, I can pull from git, but I'd use an official release version if one is coming soon) |
bLamarche413
pushed a commit
to bLamarche413/mysql
that referenced
this pull request
Mar 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #717
Description
After #669, port can be omitted. But if
tls=trueis used,tls.ServerNameis not filled.Checklist