Skip to content

do not query max_allowed_packet by default #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2017
Merged

Conversation

julienschmidt
Copy link
Member

Description

Fixes #499

The default value is from https://dev.mysql.com/doc/en/packet-too-large.html where it says "The server's default max_allowed_packet value is 4MB".

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

@julienschmidt julienschmidt added this to the v1.4 milestone Oct 7, 2017
Copy link
Member

@methane methane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julienschmidt julienschmidt merged commit eb92a8d into master Oct 12, 2017
@julienschmidt julienschmidt deleted the max_allowed_packet branch October 12, 2017 08:31
bLamarche413 pushed a commit to bLamarche413/mysql that referenced this pull request Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants