Skip to content

Export function to initialize Config with defaults #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 7, 2017
Merged

Export function to initialize Config with defaults #679

merged 4 commits into from
Oct 7, 2017

Conversation

julienschmidt
Copy link
Member

@julienschmidt julienschmidt commented Oct 6, 2017 •
edited
Loading

Description

Export a NewConfig function which sets default values for consistency with parsed DSNs.

Updates #671, #499

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

@julienschmidt julienschmidt added this to the v1.4 milestone Oct 6, 2017
@julienschmidt julienschmidt merged commit ee359f9 into master Oct 7, 2017
@julienschmidt julienschmidt deleted the dsn_defaults branch October 7, 2017 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane methane approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@julienschmidt @methane