Skip to content

rows: fix ColumnTypeNullable from flags #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2017

Conversation

omidaladini
Copy link

@omidaladini omidaladini commented Aug 16, 2017

Description

Noticed #595 and @julienschmidt's mention of the WIP branch "columntype" and tested it. The Nullability of columns are returned incorrectly. The change-set is only one character long but may save you some debugging time.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

@julienschmidt julienschmidt merged commit 10f216a into go-sql-driver:columntype Aug 17, 2017
@julienschmidt
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants