Skip to content

INFILE deregister functions #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2013
Merged

INFILE deregister functions #65

merged 1 commit into from
Apr 26, 2013

Conversation

julienschmidt
Copy link
Member

Provide functions to remove ReaderHandler and filepaths from the
registry

Provide functions to remove ReaderHandler and filepaths from the
registry
@arnehormann
Copy link
Member

LGTM, but I'd prefer not storing a map but having a callback function func(name string) io.Reader and a default implementation for reading a named file from the filesystem. That way users can handle this themselves and we can simplify the code and get rid of the dsn parameter. Anyone wanting to limit access to files can still do it by having an own whitelist and we only store and use one function (which should probably stored in the connection struct and not globally).

julienschmidt added a commit that referenced this pull request Apr 26, 2013
@julienschmidt julienschmidt merged commit 4dab05f into master Apr 26, 2013
@julienschmidt julienschmidt deleted the infile-deregister branch April 26, 2013 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants