Skip to content

sort the generic config.Params in the DSN #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2017
Merged

sort the generic config.Params in the DSN #637

merged 1 commit into from
Jul 15, 2017

Conversation

jmhodges
Copy link
Contributor

Description

This sorts the config.Params values as they are placed in the DSN.

This makes it easier for other projects to test that they are munging their DSNs
correctly and do other similar tasks.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

@jmhodges
sort the generic config.Params in the DSN
60fef69 
This sorts the config.Params values as they are placed in the DSN.

This makes it easier for other projects to test that they are munging their DSNs
correctly and do other similar tasks.
@jmhodges
Copy link
Contributor Author

This came out as a I decided to a little work for letsencrypt again as penance for not reading this repo's README.

Hope you like it! Thanks for the help.

@jmhodges
Copy link
Contributor Author

Ping!

@arnehormann arnehormann merged commit 3955978 into go-sql-driver:master Jul 15, 2017
@jmhodges
Copy link
Contributor Author

Thanks!

@jmhodges jmhodges deleted the sort_dsn branch July 16, 2017 03:21
nimakaviani pushed a commit to cloudfoundry-attic/mysql that referenced this pull request Aug 29, 2017
@jmhodges
sort the generic config.Params in the DSN (go-sql-driver#637)
7226b99 
This sorts the config.Params values as they are placed in the DSN.

This makes it easier for other projects to test that they are munging their DSNs
correctly and do other similar tasks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane methane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmhodges @methane @arnehormann