Skip to content

remove columns definition cache. #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2017
Merged

remove columns definition cache. #592

merged 1 commit into from
May 12, 2017

Conversation

methane
Copy link
Member

@methane methane commented May 11, 2017 •
edited
Loading

fixes #587

Description

Please explain the changes you made here.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

@methane methane force-pushed the remove-column-cache branch from 7530bfc to 51742f9 Compare May 11, 2017 09:23
@coveralls
Copy link

coveralls commented May 11, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.06%) to 74.535% when pulling 51742f9 on methane:remove-column-cache into 3361273 on go-sql-driver:master.

@julienschmidt julienschmidt added this to the v1.4 milestone May 11, 2017
@methane methane merged commit aeb7d3c into go-sql-driver:master May 12, 2017
@methane methane deleted the remove-column-cache branch May 12, 2017 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienschmidt julienschmidt julienschmidt approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.

runtime error: slice bounds out of range in packets.go
3 participants
@methane @coveralls @julienschmidt