rows: Invalidate connection on error in discardResults() #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
methane
reviewed
Nov 8, 2016
| @@ -700,10 +700,11 @@ func (rows *textRows) readRow(dest []driver.Value) error { | |||
| if data[0] == iEOF && len(data) == 5 { | |||
| // server_status [2 bytes] | |||
| rows.mc.status = readStatus(data[3:]) | |||
| if err := rows.mc.discardResults(); err != nil { | |||
| err := rows.mc.discardResults() | |||
| rows.mc = nil | |||
There was a problem hiding this comment.
How about rows.mc.Close() before rows.mc = nil?
When discardResults() returned any error, I don't want to reuse the connection anymore.
julienschmidt
force-pushed
the
invalidate-discardResults
branch
from
ca68952 to
a868ac0
Compare
julienschmidt
force-pushed
the
invalidate-discardResults
branch
from
a868ac0 to
0c50208
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously the connection (
mc) was not invalidated if an error occurred indiscardResults(), which causes the driver to read on an invalid connection.Checklist
Fixes #422