Skip to content

Fix error reported by go vet #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2016

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Mar 7, 2016

Description

Fix error reported by go vet

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file
$ go vet
driver_test.go:308: arg out for printf verb %t of wrong type: int
exit status 1

```
$ go vet
driver_test.go:308: arg out for printf verb %t of wrong type: int
exit status 1
```
@dveeden
Copy link
Contributor Author

dveeden commented Mar 7, 2016

I don't think the travis failure for Go: tip is related to this commit.

@dgryski
Copy link

dgryski commented Mar 7, 2016

If this failure is reproducible on tip, it could indicate an issue with the new SSA backend.

@dgryski
Copy link

dgryski commented Mar 7, 2016

Filed golang/go#14694 for the SSA code generation bug on tip.

@julienschmidt julienschmidt added this to the v1.3 milestone Mar 10, 2016
@julienschmidt
Copy link
Member

Restarted the test. It passes now 👍

LGTM

julienschmidt added a commit that referenced this pull request Mar 10, 2016
@julienschmidt julienschmidt merged commit 66312f7 into go-sql-driver:master Mar 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants