Actually zero out the bytes in the HandshakeResponse41 #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
: The specification says these bytes should be zero but the current implementation simply ignores them. Since takeSmallBuffer ends up reusing a buffer for this packet the values might not be all zeros.
julienschmidt
added a commit
that referenced
this pull request
Oct 30, 2015
Actually zero out the bytes in the HandshakeResponse320
|
Thanks! |
|
I have a thing for protocols and reading source code that implements them :) |
|
Perfect, feel free to notify us if you find more! This driver was definitely not implemented by protocol experts. I actually never worked with network protocols before when I started this driver (as a high-school student) |
|
What an impressive find! (Also, Julien, you and the community you've helped build around this repo always impress me too. This driver is a a great benefit to many companies.) |
Carrotman42
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:
The specification says these bytes should be zero but the
current implementation simply ignores them. Since
takeSmallBuffer ends up reusing a buffer for this packet the
values might not be all zeros.