read_timeout and write_timeout configuration settings. #372
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the server that's running MySQL ran out of disk space, the
mysqld
process will hold onto all connections while it waits for disk space to be freed. Unfortunately there is currently no way to timeout the connection in this situation withgo-sql-driver/mysql
.The existing
timeout
parameter is only used during initial connection establishment (driver.go:65).This PR addsread_timeout
andwrite_timeout
settings to the DSN and enforce them usingnet.Conn.SetReadDeadline
andnet.Conn.SetWriteDeadline
respectively.Let me know what you guys think.