Skip to content

Travis: test with MariaDB #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

grooverdan
Copy link

I this added tests for go-1.5 and mariadb.

Unfortunately the default config of 10.0/10.1 is causing failing tests (https://travis-ci.org/grooverdan/mysql-1/builds/76959693) so I needed to lower 1<<25 limit to 1<<23 (24 was still too high).

@julienschmidt
Copy link
Member

Error 1118: The size of BLOB/TEXT data inserted in one transaction is greater than 10% of redo log size. Increase the redo log size using innodb_log_file_size

The alternative would be to increase innodb_log_file_size, which I would prefer.

@julienschmidt julienschmidt added this to the v1.3 milestone Sep 8, 2015
@grooverdan
Copy link
Author

fair call. That would require travis-ci/travis-ci/issues/4552 to do it in a container build. I think there is fair grounds for a 50M innodb_log_file_size on travis so that might be a grounds for a setting change in https://github.com/travis-ci/travis-cookbooks/blob/master/ci_environment/mysql/templates/default/my.cnf.erb and https://github.com/travis-ci/travis-cookbooks/blob/master/ci_environment/mysql/templates/default/ramfs/my.cnf.erb.

Any other settings you want changed?

I was thinking of adding an client/server ssl certificate and user ready to use too.

@julienschmidt julienschmidt changed the title travis: mariadb and go-1.5 Travis: test with MariaDB Jan 13, 2016
@julienschmidt julienschmidt modified the milestones: v1.4, v1.3 Jan 13, 2016
@julienschmidt
Copy link
Member

After #560 we are now testing with maria10.1, however it seems like the current default configuration works.

@methane
Copy link
Member

methane commented Mar 27, 2017

I configured max_allowed_packet size on server side in #560.
That's why change in driver_test.go is not needed in #560.

@grooverdan grooverdan deleted the mariadb-travis branch March 27, 2017 21:41
@grooverdan
Copy link
Author

Good use of docker and I didn't know you could push so many settings into the matrix section of a travis file. Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants