columnsWithAlias: Only prepend table name if not empty

[julienschmidt]

Fixes Issue #357

ToDo:

• Test

[arnehormann]

I prefer moving the table name length comparison into the outer condition, e.g.

if rows.mc.cfg.columnsWithAlias && rows.columns[i].tableName != "" {
    for i, col := range rows.columns {
        columns[i] = col.tableName + "." + col.name
    }
} else {
    for i := range columns {
        columns[i] = rows.columns[i].name
    }
}

LGTM after test - if you still want to add one.

[julienschmidt]

Unless Go suddenly has Prolog style unification, I'm afraid that we can't use the index i outside the loop before we bind it inside the loop 😉

[arnehormann]

... ugh. You got me there...

[julienschmidt]

Test added; PTAL

[arnehormann]

LGTM