Skip to content

Fix number reads bytes for mysql 5.6 #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2015

Conversation

svagner
Copy link
Contributor

@svagner svagner commented Jun 18, 2015

There is fix situation then mysql return 0 bytes for NULL column. This situation can be called with run statement "show slave hosts" at mysql 5.6 with slave mysql 5.5. In this case we got panic: out of range

There is fix situation then mysql return 0 bytes for NULL column. This situation can be called with run statement "show slave hosts" at mysql 5.6 with slave mysql 5.5. In this case we got panic: out of range
@julienschmidt
Copy link
Member

Hi, please make an entry to the AUTHORS file: https://github.com/go-sql-driver/mysql/blob/master/AUTHORS

Moreover please add a comment // See issue #349 above your code, so we can easily trace it back to here when we detect a problem with that new code.

@julienschmidt julienschmidt added this to the v1.3 milestone Jun 18, 2015
@svagner
Copy link
Contributor Author

svagner commented Jun 20, 2015

Done:)

@julienschmidt
Copy link
Member

Thanks!
LGTM

julienschmidt added a commit that referenced this pull request Jun 20, 2015
Fix number reads bytes for mysql 5.6
@julienschmidt julienschmidt merged commit 6d2067f into go-sql-driver:master Jun 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants