Code

Placeholder interpolation#309

Code

Merged

julienschmidt merged 38 commits intogo-sql-driver:mastergo-sql-driver/mysql:masterfrom

arvenil:placeholderarvenil/mysql:placeholderCopy head branch name to clipboard

Feb 14, 2015

Commits

Commits on Dec 31, 2014

• Implement placeholder substitution.

  methane

  committed
  e35fa00

  Copy full SHA for e35fa00

• Query() uses client-side placeholder substitution.

  methane

  committed
  c8c9bb1

  Copy full SHA for c8c9bb1

Commits on Jan 20, 2015

• Don't send text query larger than maxPacketAllowed

  methane

  committed
  cac6129

  Copy full SHA for cac6129

• Add substitutePlaceholder option to DSN

  methane

  committed
  b7c2c47

  Copy full SHA for b7c2c47

Commits on Jan 31, 2015

• Merge remote-tracking branch 'upstream/pr/297'

  Show description for f3b82fd
  arvenil

  committed
  f3b82fd

  Copy full SHA for f3b82fd

Commits on Feb 1, 2015

• Move escape funcs to utils.go, export them, add references to mysql surce code

  arvenil

  committed
  058ce87

  Copy full SHA for 058ce87

• Add tests for escaping functions

  arvenil

  committed
  42956fa

  Copy full SHA for 42956fa

• Add basic SQL injection tests, including NO_BACKSLASH_ESCAPES sql_mode

  arvenil

  committed
  e6bf23a

  Copy full SHA for e6bf23a

Commits on Feb 7, 2015

• Test if inserted data is correctly retrieved after being escaped

  arvenil

  committed
  b473259

  Copy full SHA for b473259

Commits on Feb 8, 2015

• Don't stop test on MySQLWarnings

  Show description for 42a1efd
  methane

  committed
  42a1efd

  Copy full SHA for 42a1efd

• substitutePlaceholder -> interpolateParams

  methane

  committed
  3c8fa90

  Copy full SHA for 3c8fa90

• Add interpolateParams document to README

  methane

  committed
  6c8484b

  Copy full SHA for 6c8484b

• Fix nits pointed in pull request.

  methane

  committed
  04866ee

  Copy full SHA for 04866ee

• Add benchmark for interpolateParams()

  methane

  committed
  dd7b87c

  Copy full SHA for dd7b87c

• Don't write microseconds when Time.Nanosecond() == 0

  methane

  committed
  9faabe5

  Copy full SHA for 9faabe5

• Fix benchmark

  methane

  committed
  468b9e5

  Copy full SHA for 468b9e5

• Reduce allocs in interpolateParams.

  Show description for 0297315
  methane

  committed
  0297315

  Copy full SHA for 0297315

• Inline datetime formatting

  Show description for 0b75396
  methane

  committed
  0b75396

  Copy full SHA for 0b75396

• Remove one more allocation

  Show description for 9f84dfb
  methane

  committed
  9f84dfb

  Copy full SHA for 9f84dfb

• More acculate estimation of upper bound

  methane

  committed
  8826242

  Copy full SHA for 8826242

Commits on Feb 9, 2015

• escapeString -> escapeBackslash

  methane

  committed
  916a1f2

  Copy full SHA for 916a1f2

Commits on Feb 10, 2015

• append string... to []byte without cast.

  methane

  committed
  88aeb98

  Copy full SHA for 88aeb98

• Specialize escape functions for string

  Show description for 43536c7
  methane

  committed
  43536c7

  Copy full SHA for 43536c7

• test for escapeString*

  methane

  committed
  0c7ae46

  Copy full SHA for 0c7ae46

• Use digits10 and digits01 to format datetime.

  methane

  committed
  c285e39

  Copy full SHA for c285e39

• Round under microsecond

  methane

  committed
  fcea447

  Copy full SHA for fcea447

Commits on Feb 11, 2015

• travis: Drop Go 1.1 and add Go 1.4

  methane

  committed
  bfbe6c5

  Copy full SHA for bfbe6c5

Commits on Feb 12, 2015

• Fix typo

  methane

  committed
  d65f96a

  Copy full SHA for d65f96a

• Inlining mysqlConn.escapeBytes and mysqlConn.escapeString

  methane

  committed
  e11c825

  Copy full SHA for e11c825

• Bit detailed info about vulnerability when using multibyte encoding.

  methane

  committed
  b4f0315

  Copy full SHA for b4f0315

• Add link to StackOverflow describe vulnerability using multibyte encoding

  methane

  committed
  1fd0514

  Copy full SHA for 1fd0514

• Fix comment

  methane

  committed
  20b75cd

  Copy full SHA for 20b75cd

• Allow interpolateParams only with ascii, latin1 and utf8 collations

  methane

  committed
  e517683

  Copy full SHA for e517683

• extract function to reserve buffer

  methane

  committed
  0f22bc2

  Copy full SHA for 0f22bc2

• Fix missing db.Close()

  methane

  committed
  52a5860

  Copy full SHA for 52a5860

• Fix sentence in interpolateParams document.

  methane

  committed
  2a634df

  Copy full SHA for 2a634df

• Use blacklist to avoid vulnerability with interpolation

  methane

  committed
  90cb6c3

  Copy full SHA for 90cb6c3

Commits on Feb 13, 2015

• Adding myself to AUTHORS (however, 99% work done by @methane ;))

  arvenil

  committed
  9437b61

  Copy full SHA for 9437b61