Fix panic when failed to SetKeepAlive(). #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When SetKeepAlive fails, panic occured because mc.Close() uses unset mc.buf. Since this is before handshake, we should close socket without sending COM_QUIT.
|
Thank you! Please add yourself to the AUTHORS file. Extra points, if you can also write a test, but I think this is optional in this case. |
julienschmidt
added a commit
that referenced
this pull request
Jan 3, 2015
Fix panic when SetKeepAlive() fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SetKeepAlive fails, panic occured because mc.Close() uses
unset mc.buf. Since this is before handshake, we should close
socket without sending COM_QUIT.