Add support for returning table alias on Columns(). #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| pos += n | ||
|
|
||
| // Original table [len coded string] | ||
| n, err = skipLengthEncodedString(data[pos:]) | ||
| originalTableName, _, n, err := readLengthEncodedString(data[pos:]) |
There was a problem hiding this comment.
originalTableName is never used. Please skip it then
|
bump |
chrismoos
force-pushed
the
expose_aliases
branch
from
21c3507 to
6f71869
Compare
|
LGTM when the last to changes are done 👍 |
Currently the driver discards the column alias and the original table name. This change adds a new configuration parameter to include the table alias with the column name. This is useful because when mapping columns to structs, it is impossible to distinguish between duplicate column names when doing JOIN queries.
chrismoos
force-pushed
the
expose_aliases
branch
from
6f71869 to
3454863
Compare
|
Thank you! |
julienschmidt
added a commit
that referenced
this pull request
Jan 21, 2015
Add support for returning table alias on Columns()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the driver discards the column alias and the original table
name. This change adds a new configuration parameter to include the
table alias with the column name.
This is useful because when mapping columns to structs, it is impossible
to distinguish between duplicate column names when doing JOIN queries.