-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Microseconds #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Microseconds #249
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
1009a04
support microseconds with MySQL 5.7+
arnehormann db91787
all tests passing
arnehormann f3e6a60
PR done, all tests succeed and problematic ones are auto-skipped
arnehormann f1ab27c
Oh Travis, why have you forsaken me (sorry dear watchers)
arnehormann 6d51ca5
faster and unified date formatting, flexible lengths, better tests
arnehormann ec804a3
trying to get more information out of Travis
arnehormann e941c93
trying to get more information out of Travis II
arnehormann 7e893ef
skip offending test on misbehaving servers
arnehormann dc9e515
skip offending test on misbehaving servers - another way
arnehormann 2aa37a1
improved date formatting with inspiration from strconv
arnehormann 81d54a2
changes based on review
arnehormann 589fef4
replace panic with error, handle missing error case
arnehormann f1914b4
removed TIMESTAMP tests (still tested in TZ conversion)
arnehormann 8441731
added new TIMESTAMP test
arnehormann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not leave this here instead moving it to utils.go?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I thought it's only used in utils.go, but that's wrong.
It's also used in packets.go.
I'll change that.