changed binary date / datetime to string #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return []byte("0000-00-00"), nil | ||
| func formatBinaryDateTime(src []byte, withTime bool) (driver.Value, error) { | ||
| const zeroDateTimeMicros = "0000-00-00 00:00:00.000000" | ||
| srclen := len(src) |
There was a problem hiding this comment.
You don't need to cache the length. The great thing about how slices and strings in Go are designed, is that getting the length is just reading an int64 - no indirection, no function calls: MOVQ src+8(FP),BX
There was a problem hiding this comment.
I know. It reads smoother to me. But that's a bad habit, I'll change it.
|
PTAL |
|
LGTM, but it would be nice if we could optimize away the convT2E allocs someday. |
|
if you have an idea how to do it, I'm game :) |
arnehormann
added a commit
that referenced
this pull request
Dec 15, 2013
changed binary date / datetime to string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark at https://gist.github.com/arnehormann/7930795 shows:
1 less allocation, speedup by factor 4+ for non-zero values